> @@ -1066,20 +1066,21 @@ static const struct { > [ 0x03 ] = { cmd_request_sense, ALLOW_UA }, > [ 0x12 ] = { cmd_inquiry, ALLOW_UA }, > [ 0x1a ] = { cmd_mode_sense, /* (6) */ 0 }, > - [ 0x1b ] = { cmd_start_stop_unit, 0 }, > + [ 0x1b ] = { cmd_start_stop_unit, 0 }, /* [1] */ > [ 0x1e ] = { cmd_prevent_allow_medium_removal, 0 }, > [ 0x25 ] = { cmd_read_cdvd_capacity, CHECK_READY },
> + /* [1] handler detects and reports not ready condition itself */ Why not comment this near the actual code? The footnote scheme is pretty odd and I've not seen it anywhere else in the code. Otherwise looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>