Christoph Hellwig <h...@lst.de> writes: > On Wed, Jul 20, 2011 at 06:24:07PM +0200, Markus Armbruster wrote: >> When ide-cd is backed by a physical drive, we want the physical tray >> match the virtual one. To that end, we call bdrv_eject() on guest's >> load/eject, and bdrv_lock_medium() on guest's prevent/allow removal. >> But we don't set the initial state on device model init. Fix that. >> >> While there, also unlock on device model exit. > > Looks good, > > Reviewed-by: Christoph Hellwig <h...@lst.de> > > But wondering: do you actually use the physical CDROM passthrough?
In my opinion, it's one of the QEMU features friends don't let friends use. But it's there, I can fix it a little, so I fix it a little. A wiser man would perhaps close his eyes and move on to fix something more useful :)
