On Tue, Jul 14, 2020 at 01:51:45PM +0100, Simon John wrote: > On Tue, 14 Jul 2020 07:10:14 -0400, Michael S. Tsirkin wrote: > > On Tue, Jul 14, 2020 at 01:51:13PM +0300, Michael Tokarev wrote: > > > As found in LP#1886318, MacOS Catalina performs 2-byte reads > > > on the acpi timer address space while the spec says it should > > > be 4-byte. Allow any small reads. > > > > > > Reported-By: Simon John <g...@the-jedi.co.uk> > > > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> > > > > Simon's explanation about the history is good to have here, > > and I guess Fixes tags (both what you found and what Simon found) > > can't hurt either. I would CC stable too. > > > > Simon do you have the time to iterate on this patch or would > > you rather have Michael do it? > > Sorry, I seem to not be getting all of these emails but trying to watch the > list archive. > > I just tested Michael's v2 patch and it works fine: > > static const MemoryRegionOps acpi_pm_tmr_ops = { > .read = acpi_pm_tmr_read, > .write = acpi_pm_tmr_write, > .impl.min_access_size = 4, > .valid.min_access_size = 1, > .valid.max_access_size = 4, > .endianness = DEVICE_LITTLE_ENDIAN, > }; > > I'm happy for Michael to proceed with the patch, he's mentioned me and > linked to the launchpad bug where the history is. > > Regards. > > -- > Simon John
Great, thanks! Michael so I think the patch is fine, just some nitpicking about commit log and comments. If you can address and repost, that would be awesome! -- MST