Thomas Huth <th...@redhat.com> writes: > On 15/07/2020 16.04, Markus Armbruster wrote: >> nd_table[] contains NIC configuration for boards to pick up. Device >> code has no business looking there. Several devices do it anyway. >> Two of them already have a suitable FIXME comment: "allwinner-a10" and >> "msf2-soc". Copy it to the others: "allwinner-h3", "xlnx-versal", >> "xlnx,zynqmp", "sparc32-ledma", "riscv.sifive.u.soc". >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> hw/arm/allwinner-h3.c | 1 + >> hw/arm/xlnx-versal.c | 1 + >> hw/arm/xlnx-zynqmp.c | 1 + >> hw/dma/sparc32_dma.c | 1 + >> hw/riscv/sifive_u.c | 1 + >> 5 files changed, 5 insertions(+) > > Maybe we should add an entry to > https://wiki.qemu.org/Contribute/BiteSizedTasks for this?
I'd prefer to leave that to someone who knows how this should be done properly, and thus has a better idea on how big the bite actually is. Figuring this out myself might be more work than fixing it. > Reviewed-by: Thomas Huth <th...@redhat.com> Thanks!
