Yep I will rework on this soon. Thanks guys, Sundeep
On Thu, Jul 16, 2020 at 1:06 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > On 7/16/20 8:07 AM, Thomas Huth wrote: > > On 16/07/2020 04.59, sundeep subbaraya wrote: > >> On Wed, Jul 15, 2020 at 8:12 PM Markus Armbruster <arm...@redhat.com> > >> wrote: > >>> > >>> Philippe Mathieu-Daudé <f4...@amsat.org> writes: > >>> > >>>> On 7/15/20 4:04 PM, Markus Armbruster wrote: > >>>>> Watch this: > >>>>> > >>>>> $ qemu-system-aarch64 -M ast2600-evb -S -display none -qmp stdio > >>>>> {"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 5}, > >>>>> "package": "v5.0.0-2464-g3a9163af4e"}, "capabilities": ["oob"]}} > >>>>> {"execute": "qmp_capabilities"} > >>>>> {"return": {}} > >>>>> {"execute": "device-list-properties", "arguments": {"typename": > >>>>> "msf2-soc"}} > >>>>> Unsupported NIC model: ftgmac100 > >>>>> armbru@dusky:~/work/images$ echo $? > >>>>> 1 > >>>>> > >>>>> This is what breaks "make check SPEED=slow". > >>>>> > >>>>> Root cause is m2sxxx_soc_initfn()'s messing with nd_table[] via > >>>>> qemu_check_nic_model(). That's wrong. > >>>>> > >>>>> We fixed the exact same bug for device "allwinner-a10" in commit > >>>>> 8aabc5437b "hw/arm/allwinner-a10: Do not use nd_table in instance_init > >>>>> function". Fix this instance the same way: move the offending code to > >>>>> m2sxxx_soc_realize(), where it's less wrong, and add a FIXME comment. > >>>> > >>>> That addresses this other thread, right? > >>>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg720658.html > >>> > >>> Correct! I wasn't aware of it, thanks for making the connection. > >>> > >> > >> Thanks Markus for the fix. > > > > It's rather just a work-around that avoids the crash than a real fix. I > > think we can use it for the upcoming 5.1 release, but it would be great > > if you could rework this code for 5.2, so that the nd_table handling is > > moved to msf2-som.c instead. > > Yes this is not a 'fix' but rather a kludge. > Thomas gave some tips to work on a fix here: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg720658.html > > Thanks, > > Phil.