Daniel P. Berrangé <berra...@redhat.com> writes:
> On Thu, Jul 30, 2020 at 11:07:26AM +0200, Markus Armbruster wrote: >> Andrea Bolognani <abolo...@redhat.com> writes: >> >> > The various schemas included in QEMU use a JSON-based format which >> > is, however, strictly speaking not valid JSON. >> > >> > As a consequence, when vim tries to apply syntax highlight rules >> > for JSON (as guessed from the file name), the result is an unreadable >> > mess which mostly consist of red markers pointing out supposed errors >> > in, well, pretty much everything. >> > >> > Using Python syntax highlighting produces much better results, and >> > in fact these files already start with specially-formatted comments >> > that instruct Emacs to process them as if they were Python files. >> > >> > This commit adds the equivalent special comments for vim. >> > >> > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> > > Given that we already have emacs mode-lines, I see no reason to > not also have vim mode-lines, so regardless of the deeper discussion > I think this is patch is fine to merge in the short term > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> We could remove them all and defer to .editorconfig but I'm not going to get in the way of making our Vim brethren's lives a little easier. -- Alex Bennée