On 8/14/20 6:40 PM, Bin Meng wrote: > From: Bin Meng <bin.m...@windriver.com> > > sdhci_poweron_reset() might be needed for any SDHCI compatible > device that is built on top of the generic SDHCI device.
NAck. Please use device_legacy_reset() instead. In next patch: device_legacy_reset(DEVICE(&sdhci->slot)); Thanks, Phil. > > Signed-off-by: Bin Meng <bin.m...@windriver.com> > --- > > hw/sd/sdhci-internal.h | 1 + > hw/sd/sdhci.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h > index e8c753d..b587e8e 100644 > --- a/hw/sd/sdhci-internal.h > +++ b/hw/sd/sdhci-internal.h > @@ -342,5 +342,6 @@ void sdhci_uninitfn(SDHCIState *s); > void sdhci_common_realize(SDHCIState *s, Error **errp); > void sdhci_common_unrealize(SDHCIState *s); > void sdhci_common_class_init(ObjectClass *klass, void *data); > +void sdhci_poweron_reset(DeviceState *dev); > > #endif > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > index deac181..20f2fe0 100644 > --- a/hw/sd/sdhci.c > +++ b/hw/sd/sdhci.c > @@ -294,7 +294,7 @@ static void sdhci_reset(SDHCIState *s) > s->pending_insert_state = false; > } > > -static void sdhci_poweron_reset(DeviceState *dev) > +void sdhci_poweron_reset(DeviceState *dev) > { > /* QOM (ie power-on) reset. This is identical to reset > * commanded via device register apart from handling of the >