On Wed, Aug 19, 2020 at 08:11:46PM -0400, Eduardo Habkost wrote: > Some of the enum constant names conflict with a QOM type check > macro (SIFIVE_E_PRCI). This needs to be addressed to allow us to > transform the QOM type check macros into functions generated by > OBJECT_DECLARE_TYPE(). > > Rename all the constants to SIFIVE_E_DEV_*, to avoid conflicts. > > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > Changes v1 -> v2: > * Added more details to commit message > > --- > Cc: Palmer Dabbelt <pal...@dabbelt.com> > Cc: Alistair Francis <alistair.fran...@wdc.com> > Cc: Sagar Karandikar <sag...@eecs.berkeley.edu> > Cc: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> > Cc: qemu-ri...@nongnu.org > Cc: qemu-devel@nongnu.org > --- > include/hw/riscv/sifive_e.h | 38 ++++++++--------- > hw/riscv/sifive_e.c | 82 ++++++++++++++++++------------------- > 2 files changed, 60 insertions(+), 60 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
