Chenqun (kuhn) <kuhn.chen...@huawei.com> 于2020年8月26日周三 上午9:47写道： > > > > > Clang static code analyzer show warning: > > > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read > > > ret = event_notifier_test_and_clear(intp->interrupt); > > > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > Reported-by: Euler Robot <euler.ro...@huawei.com> > > > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> > > > Reviewed-by: Eric Auger <eric.au...@redhat.com> > > > --- > > > Cc: Alex Williamson <alex.william...@redhat.com> > > > Cc: Eric Auger <eric.au...@redhat.com> > > > Cc: Stefan Hajnoczi <stefa...@redhat.com> > > > --- > > > hw/vfio/platform.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index > > > ac2cefc9b1..869ed2c39d 100644 > > > --- a/hw/vfio/platform.c > > > +++ b/hw/vfio/platform.c > > > @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) > > > trace_vfio_intp_interrupt_set_pending(intp->pin); > > > QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, > > > intp, pqnext); > > > - ret = event_notifier_test_and_clear(intp->interrupt); > > > > Shouldn't we check the 'ret' like the other place in this function? > > Hi, Li Qiang, > > Eric、Alex、Stefan has already discussed this point in the V1 version. > https://patchwork.kernel.org/patch/11711897/
Ok I see, then Reviewed-by: Li Qiang <liq...@gmail.com> Thanks, Li Qiang > > Thanks.
