On Thu, 27 Aug 2020 at 08:01, Chenqun (kuhn) <kuhn.chen...@huawei.com> wrote: > > > Subject: Re: [PATCH v2 09/10] hw/intc: Remove redundant statement in > > exynos4210_combiner_read()
> > The code as it stands is definitely wrong, but I'm not sure this is the > > correct fix. > > Surely the intention must have been to return the actual register value from > > the reg_set[] array, not to return 0 ? > > > > I suspect the correct fix here is simply to delete the "return 0" line and > > leave > > the assignment to val as it is. > > Hi Peter, > I think you're right. > > > Ideally you should check the h/w datasheet to confirm. > I checked the Exynos 4210 datasheet and found that 'Interrupt Combiner > Operation' had only five types of registers. > Please confirm that if there is no problem, I will modify it in later version. Thanks for checking the datasheet -- I agree and we should keep the "val = s->reg_set[offset >> 2];" and only delete the "return 0". -- PMM
