I am just compiling with cflag set to -Wimplicit-fallthrough. I am using gcc.
On Tue, Aug 25, 2020 at 2:03 AM Markus Armbruster <arm...@redhat.com> wrote: > Rohit Shinde <rohit.shinde12...@gmail.com> writes: > > > Added fallthrough comment on line 270 to prevent the compiler from > > throwing an error while compiling with the -Wimplicit-fallthrough flag > > None of the compilers I know warns there. Which one are you using? > > Commit message style tip: use the imperative mood > https://chris.beams.io/posts/git-commit/#imperative > > > Signed-off-by: Rohit Shinde <rohit.shinde12...@gmail.com> > > --- > > qapi/opts-visitor.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c > > index 7781c23a42..3422ff265e 100644 > > --- a/qapi/opts-visitor.c > > +++ b/qapi/opts-visitor.c > > @@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t > size) > > } > > ov->list_mode = LM_IN_PROGRESS; > > /* range has been completed, fall through in order to pop > option */ > > + /* fallthrough */ > > > > case LM_IN_PROGRESS: { > > const QemuOpt *opt; > >
