On Mon, Aug 31, 2020 at 01:43:07PM -0500, Babu Moger wrote: > apic_id contains all the information required to build > CPUID_8000_001E. core_id and node_id is already part of > apic_id generated by x86_topo_ids_from_apicid. > > Also remove the restriction on number bits on core_id and > node_id. > > Remove all the hardcoded values and replace with generalized > fields. > > Refer the Processor Programming Reference (PPR) documentation > available from the bugzilla Link below. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537 > Signed-off-by: Babu Moger <babu.mo...@amd.com> > --- [...] > @@ -6019,7 +5914,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, > uint32_t count, > break; > case 0x8000001E: > assert(cpu->core_id <= 255);
I assume we still want to remove this assert()? Do you plan to redo and resubmit Subject: [PATCH] target/i386: Remove core_id assert check in CPUID 0x8000001E https://lore.kernel.org/qemu-devel/159257395689.52908.4409314503988289481.st...@naples-babu.amd.com ? > - encode_topo_cpuid8000001e(cs, cpu, > + encode_topo_cpuid8000001e(cpu, &topo_info, > eax, ebx, ecx, edx); > break; > case 0xC0000000: > > -- Eduardo