On Wed, Sep 23, 2020 at 06:13:30PM -0400, John Snow wrote: > On 9/23/20 3:15 PM, Eduardo Habkost wrote: > > On Tue, Sep 22, 2020 at 05:00:59PM -0400, John Snow wrote: > > > Signed-off-by: John Snow <js...@redhat.com> > > > > This for making mypy happy, correct? An explanation in the commit > > message would be nice. > > > > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > > > > Yes, it's for mypy -- but it's a runtime visible change. Technically our > type system isn't mature enough to express this constraint natively, so it's > being carried around as developer knowledge. > > This formalizes that knowledge, albeit in a very crude way. > > I've amended the commit msg.
OK, this answers my previous question about why it was handled as an assert. - Cleber.
signature.asc
Description: PGP signature
