On Tue, Sep 22, 2020 at 05:00:59PM -0400, John Snow wrote: > Signed-off-by: John Snow <js...@redhat.com> > --- > scripts/qapi/visit.py | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py > index 4edaee33e3..180c140180 100644 > --- a/scripts/qapi/visit.py > +++ b/scripts/qapi/visit.py > @@ -22,7 +22,10 @@ > indent, > ) > from .gen import QAPISchemaModularCVisitor, ifcontext > -from .schema import QAPISchemaObjectType > +from .schema import ( > + QAPISchemaEnumType, > + QAPISchemaObjectType, > +) > > > def gen_visit_decl(name, scalar=False): > @@ -84,15 +87,17 @@ def gen_visit_object_members(name, base, members, > variants): > ret += gen_endif(memb.ifcond) > > if variants: > + tag_member = variants.tag_member > + assert isinstance(tag_member.type, QAPISchemaEnumType) > +
I'd be interested in knowing why this wasn't left to be handled by the type checking only. Anyway, Reviewed-by: Cleber Rosa <cr...@redhat.com>
signature.asc
Description: PGP signature
