On 10/7/20 1:58 AM, John Snow wrote: > These arguments don't need to be mutable and aren't really used as > such. Clarify their types as immutable and adjust code to match where > necessary. > > In general, It's probably best not to accept a user-defined mutable > object and store it as internal object state unless there's a strong > justification for doing so. Instead, try to use generic types as input > with empty tuples as the default, and coerce to list where necessary. > > Signed-off-by: John Snow <js...@redhat.com> > Reviewed-by: Kevin Wolf <kw...@redhat.com> > --- > python/qemu/machine.py | 30 +++++++++++++++++------------- > python/qemu/qtest.py | 22 +++++++++++++++++----- > 2 files changed, 34 insertions(+), 18 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
