Am 07.10.2020 um 01:58 hat John Snow geschrieben: > These should all be purely annotations with no changes in behavior at > all. You need to be in the python folder, but you should be able to > confirm that these annotations are correct (or at least self-consistent) > by running `mypy --strict qemu`. > > Signed-off-by: John Snow <js...@redhat.com>
'mypy --strict qemu' doesn't have clean output after this patch because ConsoleSocket isn't converted yet. But then, technically the commit message doesn't make this claim, and you can indeed check the self-consistency when you ignore the ConsoleSocket related errors, so probably not a problem. Reviewed-by: Kevin Wolf <kw...@redhat.com>