On 12/10/2020 15.13, Thomas Huth wrote: > On 08/10/2020 18.03, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> >> >> In travis, with gcov and gprof we're seeing timeouts; hopefully fix >> this by increasing the test timeouts a bit, but for xbzrle ensure it >> really does get a couple of cycles through to test the cache. >> >> I think the problem in travis is we have about 2 host CPU threads, >> in the test we have at least 3: >> a) The vCPU thread (100% flat out) >> b) The source migration thread >> c) The destination migration thread >> >> if (b) & (c) are slow for any reason - gcov+gperf or a slow host - >> then they're sharing one host CPU thread so limit the migration >> bandwidth. >> >> Tested on my laptop with: >> taskset -c 0,1 ./tests/qtest/migration-test -p /x86_64/migration >> >> Reported-by: Alex Bennée <alex.ben...@linaro.org> >> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> >> --- >> tests/qtest/migration-test.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) > > This seems to fix the gcov/gprof test indeed: > > https://travis-ci.com/github/huth/qemu/jobs/398270396 > > Thus: > > Tested-by: Thomas Huth <th...@redhat.com> > > I'm also queuing this to my qtest-next branch (in case you don't plan a > migration pull request within the next days): > > https://gitlab.com/huth/qemu/-/commits/qtest-next/
FYI, this patch fails to build on non-Linux systems: https://cirrus-ci.com/task/5951706225704960?command=main#L6076 The #define needs to be moved out of the #if defined(__linux__) block. I can fixup the patch here locally, but if you want to include it in your next migration pull request instead, you should do that, too. Cheers, Thomas