On Tue, 20 Oct 2020 at 12:03, Gan Qixin <ganqi...@huawei.com> wrote: > > Hi all, > I used scripts/checkpatch.pl to find that many files in the hw directory > contain lines with more than 80 characters. Therefore, I splited some lines to > fix this warning.
I personally have come round to the idea that we should instead adjust checkpatch so that it doesn't have a hard 80 character complaint limit. Compare the kernel coding style change: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 whose rationale I agree with. We should *prefer* 80 character wrapping, but there are some places where an 85-character line is much more readable and sensible style than inserting a line break just to please checkpatch. thanks -- PMM
