> -----Original Message----- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, October 20, 2020 7:15 PM > To: ganqixin <ganqi...@huawei.com> > Cc: QEMU Developers <qemu-devel@nongnu.org>; QEMU Trivial > <qemu-triv...@nongnu.org>; Michael S. Tsirkin <m...@redhat.com>; Philippe > Mathieu-Daudé <f4...@amsat.org>; Laurent Vivier <lviv...@redhat.com>; > David Gibson <da...@gibson.dropbear.id.au>; Alistair Francis > <alistair.fran...@wdc.com>; Chenqun (kuhn) <kuhn.chen...@huawei.com>; > Zhanghailiang <zhang.zhanghaili...@huawei.com> > Subject: Re: [PATCH 00/10] Fix line over 80 characters warning > > On Tue, 20 Oct 2020 at 12:03, Gan Qixin <ganqi...@huawei.com> wrote: > > > > Hi all, > > I used scripts/checkpatch.pl to find that many files in the hw > > directory contain lines with more than 80 characters. Therefore, I > > splited some lines to fix this warning. > > I personally have come round to the idea that we should instead adjust > checkpatch so that it doesn't have a hard 80 character complaint limit. >
Hi Peter, It sounds like a good idea, I think I can try to modify checkpatch.pl by referring to the Linux patch. Thanks, Gan Qixin > Compare the kernel coding style change: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id= > bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > whose rationale I agree with. We should *prefer* 80 character wrapping, but > there are some places where an 85-character line is much more readable and > sensible style than inserting a line break just to please checkpatch. > > thanks > -- PMM
