On 10/28/20 5:18 AM, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> target/sparc/translate.c: In function ‘gen_st_asi’:
> target/sparc/translate.c:2320:12: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 2320 | if (!(dc->def->features & CPU_FEATURE_HYPV)) {
> | ^
> target/sparc/translate.c:2329:5: note: here
> 2329 | case GET_ASI_DIRECT:
> | ^~~~
>
> The "fall through" statement place is not correctly identified by the
> compiler.
>
> Reported-by: Euler Robot <euler.ro...@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
> ---
> Cc: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
> Cc: Artyom Tarasenko <atar4q...@gmail.com>
> ---
> target/sparc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/sparc/translate.c b/target/sparc/translate.c
> index 1a4efd4ed6..a3d9aaa46b 100644
> --- a/target/sparc/translate.c
> +++ b/target/sparc/translate.c
> @@ -2324,8 +2324,8 @@ static void gen_st_asi(DisasContext *dc, TCGv src, TCGv
> addr,
> }
> /* in OpenSPARC T1+ CPUs TWINX ASIs in store instructions
> * are ST_BLKINIT_ ASIs */
> - /* fall through */
> #endif
> + /* fall through */
> case GET_ASI_DIRECT:
> gen_address_mask(dc, addr);
> tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop);
>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
