On 10/28/20 5:18 AM, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > target/sparc/win_helper.c: In function ‘get_gregset’: > target/sparc/win_helper.c:304:9: warning: this statement may fall through > [-Wimplicit-fallthrough=] > 304 | trace_win_helper_gregset_error(pstate); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > target/sparc/win_helper.c:306:5: note: here > 306 | case 0: > | ^~~~ > > Add the corresponding "fall through" comment to fix it. > > Reported-by: Euler Robot <euler.ro...@huawei.com> > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> > --- > Cc: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > Cc: Artyom Tarasenko <atar4q...@gmail.com> > --- > target/sparc/win_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/sparc/win_helper.c b/target/sparc/win_helper.c > index 8290a21142..32eacc05e6 100644 > --- a/target/sparc/win_helper.c > +++ b/target/sparc/win_helper.c > @@ -303,6 +303,7 @@ static inline uint64_t *get_gregset(CPUSPARCState *env, > uint32_t pstate) > default: > trace_win_helper_gregset_error(pstate); > /* pass through to normal set of global registers */ > + /* fall through */
Can you keep the comment, doing s/pass/fall/? > case 0: > return env->bgregs; > case PS_AG: >
