On Mon, 2 Nov 2020 at 20:36, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > Fix uninitialized value issues reported by Coverity: > > Field 'msg.reserved' is uninitialized when calling write(). > > Reported-by: Coverity (CID 1432864: UNINIT) > Fixes: c471ad0e9bd ("vhost_net: device IOTLB support") > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/virtio/vhost-backend.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c > index 88c8ecc9e03..222bbcc62de 100644 > --- a/hw/virtio/vhost-backend.c > +++ b/hw/virtio/vhost-backend.c > @@ -257,7 +257,7 @@ static int vhost_kernel_send_device_iotlb_msg(struct > vhost_dev *dev, > struct vhost_iotlb_msg *imsg) > { > if (dev->backend_cap & (1ULL << VHOST_BACKEND_F_IOTLB_MSG_V2)) { > - struct vhost_msg_v2 msg; > + struct vhost_msg_v2 msg = {}; > > msg.type = VHOST_IOTLB_MSG_V2; > msg.iotlb = *imsg; > @@ -267,7 +267,7 @@ static int vhost_kernel_send_device_iotlb_msg(struct > vhost_dev *dev, > return -EFAULT; > } > } else { > - struct vhost_msg msg; > + struct vhost_msg msg = {}; > > msg.type = VHOST_IOTLB_MSG; > msg.iotlb = *imsg;
Coverity didn't mind about the struct vhost_msg because it doesn't have a 'reserved' field like vhost_msg_v2; but it doesn't hurt to initialize it and it makes the two parts of the function consistent, which is good. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM