Hi Peter,
Sorry to get these out so late, for some inexplicable reason my email
client decided to flag all responses v1 as spam and I didn't notice
until I double-checked the archives this morning.
I've fixed the gcc-on-BSD and clang-on-linux issues you pointed out
(PATCH 6) and added proper test coverage for both.
Also, the qga-ssh-test unit test introduced in this series triggers a
failure in Gitlab CI build-oss-fuzz test. This seems to be due to a
memory leak in GLib itself when G_TEST_OPTION_ISOLATE_DIRS option is
passed to g_test_init(). I verified the unit test doesn't introduce any
leaks when run without g_test* harness. Since G_TEST_OPTION_ISOLATE_DIRS
is currently needed to safely run the qga-ssh-test, I've disabled it for
now (PATCH 9 and 12) until we figure out solution.
Thanks,
Mike
The following changes since commit 2c6605389c1f76973d92b69b85d40d94b8f1092c:
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201101.0'
into staging (2020-11-02 09:54:00 +0000)
are available in the Git repository at:
git://github.com/mdroth/qemu.git tags/qga-pull-2020-10-27-v2-tag
for you to fetch changes up to b457991dfb801bf9227e8823534de5dbb3c276c1:
qga: add ssh-get-authorized-keys (2020-11-02 18:30:42 -0600)
----------------------------------------------------------------
qemu-ga patch queue for soft-freeze
* add guest-get-disks for w32/linux
* add guest-{add,remove,get}-authorized-keys
* fix API violations and schema documentation inconsistencies with
recently-added guest-get-devices
v2:
- fix BSD build error due to missing stub for guest_get_disks
- fix clang build error on linux due to unused variable
- disable qga-ssh-test for now due to a memory leak within GLib when
G_TEST_OPTION_ISOLATE_DIRS is passed to g_test_init() since it
break Gitlab CI build-oss-fuzz test
- rebased and re-tested on master
----------------------------------------------------------------
Marc-André Lureau (5):
glib-compat: add g_unix_get_passwd_entry_qemu()
qga: add ssh-{add,remove}-authorized-keys
qga: add *reset argument to ssh-add-authorized-keys
meson: minor simplification
qga: add ssh-get-authorized-keys
Markus Armbruster (4):
qga: Rename guest-get-devices return member 'address' to 'id'
qga: Use common time encoding for guest-get-devices 'driver-date'
qga-win: Fix guest-get-devices error API violations
qga: Flatten simple union GuestDeviceId
Tomáš Golembiovský (3):
qga: add command guest-get-disks
qga: add implementation of guest-get-disks for Linux
qga: add implementation of guest-get-disks for Windows
include/glib-compat.h | 26 +++
qga/commands-posix-ssh.c | 516 +++++++++++++++++++++++++++++++++++++++++++++++
qga/commands-posix.c | 297 ++++++++++++++++++++++++++-
qga/commands-win32.c | 140 +++++++++++--
qga/meson.build | 39 +++-
qga/qapi-schema.json | 127 +++++++++++-
6 files changed, 1104 insertions(+), 41 deletions(-)
create mode 100644 qga/commands-posix-ssh.c
