On Fri, 6 Nov 2020 at 18:19, Pavel Pisa <p...@cmp.felk.cvut.cz> wrote: > On Friday 06 of November 2020 18:11:53 Peter Maydell wrote: > > Instead of casting an address within a uint8_t array to a > > uint32_t*, use stl_le_p(). This handles possibly misaligned > > addresses which would otherwise crash on some hosts. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > ---
> even that I do not like stl_le_p name, because it differs from the Linux > kernel one. cpu_to_le32 matches. The pointer variant is cpu_to_le32p > on Linux kernel side, I think. stl is strange name and l for long > is problematic as well, if it is st32_le_p or st_le32_p I would recognize > that much easier. QEMU is not the kernel. We have our own naming conventions and our own APIs. I agree that the b/w/l/q suffixing is less intuitive than 8/16/32/64, but we have a lot of functions using that convention, and the API is what it is. thanks -- PMM