On 11/6/20 7:31 PM, Philippe Mathieu-Daudé wrote: > On 11/6/20 6:11 PM, Peter Maydell wrote: >> Instead of casting an address within a uint8_t array to a >> uint32_t*, use stl_le_p(). This handles possibly misaligned >> addresses which would otherwise crash on some hosts. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> hw/net/can/ctucan_core.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/hw/net/can/ctucan_core.c b/hw/net/can/ctucan_core.c >> index f2ce978e5ec..e66526efa83 100644 >> --- a/hw/net/can/ctucan_core.c >> +++ b/hw/net/can/ctucan_core.c >> @@ -305,8 +305,7 @@ void ctucan_mem_write(CtuCanCoreState *s, hwaddr addr, >> uint64_t val, >> addr %= CTUCAN_CORE_TXBUFF_SPAN; >> assert(buff_num < CTUCAN_CORE_TXBUF_NUM); >> if (addr < sizeof(s->tx_buffer[buff_num].data)) { >> - uint32_t *bufp = (uint32_t *)(s->tx_buffer[buff_num].data + >> addr); >> - *bufp = cpu_to_le32(val); >> + stl_le_p(s->tx_buffer[buff_num].data + addr, val); > > Out of curiosity, how did you notice? Passing by while reviewing?
$ git grep -P '^\s+\*.*=.*(cpu_to.*|to_cpu)\('|wc -l 82