On Fri, Nov 13, 2020 at 01:13:42PM +0000, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Fri, 13 Nov 2020 at 09:59, Changbin Du <changbin...@gmail.com> wrote: > > > > > > This adds hmp 'info tlb' command support for the arm platform. > > > The limitation is that this only implements a page walker for > > > ARMv8-A AArch64 Long Descriptor format, 32bit addressing is > > > not supported yet. > > > > "info tlb" needs its own entirely independent implementation > > of a page-table walk? I see this is how x86 has done it ,but > > it seems like a recipe for the info command being perpetually > > behind what we actually implement... > > I think the challenge is you want 'info tlb' to be quite easy > to read from a debuggers point of view and robust at pointing out > things that are odd; I'd hope at least you can use most of the macros > to extract fields etc > Actually I refered to function get_phys_addr_lpae() and try to use definitions what I found. But most of the bit definitions are hardcode.
I have fixed the code style issues in V2. Thanks for your kind review! > Dave > > > thanks > > -- PMM > > > -- > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK > -- Cheers, Changbin Du