On 11/15/20 7:48 PM, Gan Qixin wrote: > The category of the u2f-passthru device is not set, put it into the 'usb' > category.
I guess we discussed this with Thomas 1 or 2 years ago but I don't remember. I think it was about using set_bits() so devices can appear in multiple categories. Gerd, do you know what is the point of the "usb" category for management apps? This is a bus accepting multiple better categorized devices (display, storage, input, network, sound). Unrelated but multiple devices are related to SECURITY. Maybe it is time to introduce the DEVICE_CATEGORY_SECURITY? > > Signed-off-by: Gan Qixin <ganqi...@huawei.com> > --- > Cc: Gerd Hoffmann <kra...@redhat.com> > --- > hw/usb/u2f-passthru.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/usb/u2f-passthru.c b/hw/usb/u2f-passthru.c > index ae00e93f35..000822f396 100644 > --- a/hw/usb/u2f-passthru.c > +++ b/hw/usb/u2f-passthru.c > @@ -534,6 +534,7 @@ static void u2f_passthru_class_init(ObjectClass *klass, > void *data) > dc->desc = "QEMU U2F passthrough key"; > dc->vmsd = &u2f_passthru_vmstate; > device_class_set_props(dc, u2f_passthru_properties); > + set_bit(DEVICE_CATEGORY_USB, dc->categories); > } > > static const TypeInfo u2f_key_passthru_info = { >