On Tue, 1 Dec 2020 at 15:16, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 11/19/20 3:56 PM, Peter Maydell wrote: > > + } else { > > + /* BFHFNMIGN is RAZ/WI from NS if AIRCR.BFHFNMINS is 0 */ > > + if (!(cpu->env.v7m.aircr & R_V7M_AIRCR_BFHFNMINS_MASK)) { > > + value &= ~R_V7M_CCR_BFHFNMIGN_MASK; > > + } > > This isn't WI, as you're zeroing the bit not preserving it. > I think you need to merge the current state of the bit to preserve the value > for secure state.
Oops, yes. thanks -- PMM