On 07/12/2020 09.05, ganqixin wrote: >> -----Original Message----- >> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >> Sent: Friday, December 4, 2020 9:50 PM >> To: ganqixin <ganqi...@huawei.com>; qemu-devel@nongnu.org; >> qemu-triv...@nongnu.org >> Cc: Chenqun (kuhn) <kuhn.chen...@huawei.com>; Zhanghailiang >> <zhang.zhanghaili...@huawei.com>; Gerd Hoffmann >> <kra...@redhat.com>; th...@redhat.com >> Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category >> >> On 11/17/20 2:37 PM, ganqixin wrote: >>>> -----Original Message----- >>>> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >>>> Sent: Monday, November 16, 2020 10:05 PM >>>> To: ganqixin <ganqi...@huawei.com>; qemu-devel@nongnu.org; >>>> qemu-triv...@nongnu.org; Marc-André Lureau >>>> <marcandre.lur...@redhat.com>; th...@redhat.com >>>> Cc: Chenqun (kuhn) <kuhn.chen...@huawei.com>; Zhanghailiang >>>> <zhang.zhanghaili...@huawei.com>; Gerd Hoffmann >> <kra...@redhat.com>; >>>> Eduardo Habkost <ehabk...@redhat.com> >>>> Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' >>>> category >>>> >>>> On 11/15/20 7:48 PM, Gan Qixin wrote: >>>>> The category of the u2f-passthru device is not set, put it into the 'usb' >>>>> category. >>>> >>>> I guess we discussed this with Thomas 1 or 2 years ago but I don't >> remember. >>>> I think it was about using set_bits() so devices can appear in >>>> multiple categories. >>>> >>>> Gerd, do you know what is the point of the "usb" category for >>>> management apps? This is a bus accepting multiple better categorized >>>> devices (display, storage, input, network, sound). >>>> >>>> Unrelated but multiple devices are related to SECURITY. >>>> Maybe it is time to introduce the DEVICE_CATEGORY_SECURITY? >>> >>> Hi, Philippe >>> Thanks for your reply, but I'm not sure if it is appropriate to add a >> security category to place this device. >>> (Maybe it's because I don't know much about these device, I haven't >>> find many safety-related devices in 'misc' category or uncategorized >>> devices) >> >> What is the difference between 'misc' and 'uncategorized'? > > In my opinion, devices that we forgot to classify will appear in > "uncategorized" list, and devices that don't have a suitable category to > choose will be put into "misc" category.
That's right. User-creatable devices should have a category, and the uncategorized devices just have not been categorized yet. So thanks for tackling this, Gan Qixin! Thomas
