On 12/15/20 8:01 PM, frank.ch...@sifive.com wrote: > +static bool trans_sloi(DisasContext *ctx, arg_sloi *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + > + if (a->shamt >= TARGET_LONG_BITS) { > + return false; > + }
As I mentioned vs the previous patch, these checks should be in gen_shifti. Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~