On 12/24/20 11:29 AM, Paolo Bonzini wrote:
> On 24/12/20 09:26, Cédric Le Goater wrote:
>> In hw/ppc/Kconfig :
>>
>> config POWERNV
>> ...
>> select XICS
>> select XIVE
>>
>> config PSERIES
>> ...
>> select XICS_SPAPR
>> select XIVE_SPAPR
>>
>> and in hw/intc/meson.build :
>>
>> specific_ss.add(when: 'CONFIG_POWERNV', if_true: files('xics_pnv.c',
>> 'pnv_xive.c'))
>> ...
>> specific_ss.add(when: 'CONFIG_XICS_SPAPR', if_true: files('xics_spapr.c'))
>> specific_ss.add(when: 'CONFIG_XIVE_SPAPR', if_true: files('spapr_xive.c'))
>> ...
>>
>>
>> Couldn't we simply select XICS and XIVE in the PSERIES machine and
>> compile 'xics_spapr.c' and 'spapr_xive.c' when CONFIG_PSERIES is
>> defined ? This to be in sync with the POWERNV machine.
>> or introduce 'CONFIG_XICS_PNV 'CONFIG_XIVE_PNV' ?
>
> I think just using CONFIG_PSERIES is the simplest. But it's just a cleanup,
> not a bugfix.
yes. No big deal and it can come later.
Reviewed-by: Cédric Le Goater <c...@kaod.org>
Cheers,
C.
