On 1/19/21 4:50 AM, Peter Maydell wrote: > On Fri, 15 Jan 2021 at 21:14, Richard Henderson > <richard.hender...@linaro.org> wrote: >> >> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> >> --- >> tcg/mips/tcg-target-con-str.h | 24 ++++++++++++ >> tcg/mips/tcg-target.h | 1 + >> tcg/mips/tcg-target.c.inc | 72 ++++++++--------------------------- >> 3 files changed, 41 insertions(+), 56 deletions(-) >> create mode 100644 tcg/mips/tcg-target-con-str.h > >> - case 'Z': >> - /* We are cheating a bit here, using the fact that the register >> - ZERO is also the register number 0. Hence there is no need >> - to check for const_args in each instruction. */ >> - ct->ct |= TCG_CT_CONST_ZERO; > > This comment seems like it's worth retaining somewhere.
I moved it to the start of tcg_out_op, which is where we do the operand checking, and therefore perhaps more usefully placed. r~
