On 1/15/21 12:13 PM, Alistair Francis wrote: >> +#define ALL_GENERAL_REGS 0xffffffffu >> +#ifdef CONFIG_SOFTMMU >> +#define ALL_QLDST_REGS \ >> + (ALL_GENERAL_REGS & ~((1 << TCG_REG_A0) | (1 << TCG_REG_A1) | \ >> + (1 << TCG_REG_A2) | (1 << TCG_REG_A3) | \ >> + (1 << TCG_REG_A5))) > > Why is this not TCG_REG_A4?
I've changed this to #define ALL_GENERAL_REGS MAKE_64BIT_MASK(0, 32) /* * For softmmu, we need to avoid conflicts with the first 5 * argument registers to call the helper. Some of these are * also used for the tlb lookup. */ #ifdef CONFIG_SOFTMMU #define SOFTMMU_RESERVE_REGS MAKE_64BIT_MASK(TCG_REG_A0, 5) #else #define SOFTMMU_RESERVE_REGS 0 #endif r~
