On 2/12/21 2:45 PM, Peter Maydell wrote: > On Fri, 5 Feb 2021 at 17:00, Peter Maydell <peter.mayd...@linaro.org> wrote: >> >> MPS3 boards have an extra SWITCH register in the FPGAIO block which >> reports the value of some switches. Implement this, governed by a >> property the board code can use to specify whether whether it exists. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> include/hw/misc/mps2-fpgaio.h | 1 + >> hw/misc/mps2-fpgaio.c | 10 ++++++++++ >> 2 files changed, 11 insertions(+) > > I changed my mind about the property/struct field name here, I think > "has" is what we tend to use rather than "have". Trivial change > to squash into this patch:
What about "use-switches"? use-x: 12 occurences has-x: 9. Is there a difference in the meaning? Maybe have refers to something internal, while use to something external? $ git grep -F 'DEFINE_PROP_BOOL("use-' hw/audio/hda-codec.c:848: DEFINE_PROP_BOOL("use-timer", HDAAudioState, use_timer, true), hw/block/nvme.c:4556: DEFINE_PROP_BOOL("use-intel-id", NvmeCtrl, params.use_intel_id, false), hw/intc/ppc-uic.c:278: DEFINE_PROP_BOOL("use-vectors", PPCUIC, use_vectors, true), hw/ppc/spapr_rng.c:135: DEFINE_PROP_BOOL("use-kvm", SpaprRngState, use_kvm, false), hw/virtio/virtio.c:3722: DEFINE_PROP_BOOL("use-started", VirtIODevice, use_started, true), hw/virtio/virtio.c:3723: DEFINE_PROP_BOOL("use-disabled-flag", VirtIODevice, use_disabled_flag, true), target/microblaze/cpu.c:292: DEFINE_PROP_BOOL("use-stack-protection", MicroBlazeCPU, cfg.stackprot, target/microblaze/cpu.c:311: DEFINE_PROP_BOOL("use-barrel", MicroBlazeCPU, cfg.use_barrel, true), target/microblaze/cpu.c:312: DEFINE_PROP_BOOL("use-div", MicroBlazeCPU, cfg.use_div, true), target/microblaze/cpu.c:313: DEFINE_PROP_BOOL("use-msr-instr", MicroBlazeCPU, cfg.use_msr_instr, true), target/microblaze/cpu.c:314: DEFINE_PROP_BOOL("use-pcmp-instr", MicroBlazeCPU, cfg.use_pcmp_instr, true), target/microblaze/cpu.c:315: DEFINE_PROP_BOOL("use-mmu", MicroBlazeCPU, cfg.use_mmu, true), $ git grep -F 'DEFINE_PROP_BOOL("has-' hw/gpio/imx_gpio.c:295: DEFINE_PROP_BOOL("has-edge-sel", IMXGPIOState, has_edge_sel, true), hw/gpio/imx_gpio.c:296: DEFINE_PROP_BOOL("has-upper-pin-irq", IMXGPIOState, has_upper_pin_irq, hw/intc/arm_gic_common.c:357: DEFINE_PROP_BOOL("has-security-extensions", GICState, security_extn, 0), hw/intc/arm_gic_common.c:359: DEFINE_PROP_BOOL("has-virtualization-extensions", GICState, virt_extn, 0), hw/intc/arm_gicv3_common.c:497: DEFINE_PROP_BOOL("has-security-extensions", GICv3State, security_extn, 0), hw/misc/macio/macio.c:430: DEFINE_PROP_BOOL("has-pmu", NewWorldMacIOState, has_pmu, false), hw/misc/macio/macio.c:431: DEFINE_PROP_BOOL("has-adb", NewWorldMacIOState, has_adb, false), hw/misc/macio/pmu.c:782: DEFINE_PROP_BOOL("has-adb", PMUState, has_adb, true), target/arm/cpu.c:1110: DEFINE_PROP_BOOL("has-mpu", ARMCPU, has_mpu, true);