Looks quite good, didn't have any more comments. We can use it for streaming with non shared storage with minor changes (http://wiki.qemu.org/Features/LiveBlockMigration#ISCSI_for_non_shared_storage) Ronnie , are you looking into ISCSI target too?
Orit On Mon, 2011-09-12 at 10:56 +0200, Kevin Wolf wrote: > Am 10.09.2011 06:23, schrieb Ronnie Sahlberg: > > List, > > > > Please find a patch that adds built-in iSCSI support to QEMU when built and > > linked against the multiplatform iscsi initiator library at > > git://github.com/sahlberg/libiscsi.git > > > > All previous comments and suggestions have been addressed in this patch. > > > > I and others have done extensive testing and used this patch extensively > > over the last ~6 months with great result. > > > > > > In some situations, using a built-in iscsi inititator has benefits against > > mounting the LUNs on the host. > > > > * Privacy: The iSCSI LUNs are private to the guest and are not visible > > either to the host, nor to any processes running on the host. > > * Ease of managment : If you have very many guests and very many, thousands > > of, iSCSI LUNs. It is inconvenient to have to expose all LUNs to the > > underlying host. > > * No root requirement. Since the iSCSI LUNs are not mounted as devices on > > the host, ordinary users can set up and use iSCSI resources without the > > need for root privilege on the host to map the devices to local scsi > > devices. > > > > > > Please merge this patch to master or explain how I should change the patch > > so that it becomes acceptable for inclusion into QEMU. > > Orit, I think you could be interested in reviewing this patch? > > Kevin >