On Tue, Feb 23, 2021 at 04:35:41PM +0100, Philippe Mathieu-Daudé wrote: > On 2/23/21 4:27 PM, Philippe Mathieu-Daudé wrote: > > On 2/19/21 10:58 PM, Cleber Rosa wrote: > >> The QEMU project has two machines (aarch64 and s390x) that can be used > >> for jobs that do build and run tests. This introduces those jobs, > >> which are a mapping of custom scripts used for the same purpose. > >> > >> Signed-off-by: Cleber Rosa <cr...@redhat.com> > >> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > >> --- > >> .gitlab-ci.d/custom-runners.yml | 204 ++++++++++++++++++++++++++++++++ > >> 1 file changed, 204 insertions(+) > >> > >> diff --git a/.gitlab-ci.d/custom-runners.yml > >> b/.gitlab-ci.d/custom-runners.yml > >> index 3004da2bda..a9166c82a2 100644 > >> --- a/.gitlab-ci.d/custom-runners.yml > >> +++ b/.gitlab-ci.d/custom-runners.yml > >> @@ -12,3 +12,207 @@ > >> # strategy. > >> variables: > >> GIT_SUBMODULE_STRATEGY: recursive > >> + > >> +# All ubuntu-18.04 jobs should run successfully in an environment > >> +# setup by the scripts/ci/setup/build-environment.yml task > >> +# "Install basic packages to build QEMU on Ubuntu 18.04/20.04" > >> +ubuntu-18.04-s390x-all-linux-static: > >> + allow_failure: true > >> + needs: [] > >> + stage: build > >> + tags: > >> + - ubuntu_18.04 > >> + - s390x > >> + rules: > >> + - if: '$CI_COMMIT_BRANCH =~ /^staging/' > > > > Maybe this is too restrictive, we might want to test /master too. > > Also now all fork pipelines are stuck... > > This job is stuck because you don't have any active runners online > or available with any of these tags assigned to them: s390x > ubuntu_18.04 > Go to project CI settings > > https://gitlab.com/philmd/qemu/-/jobs/1050123478 > > What about using as starter: > > rules: > if: '$CI_PROJECT_PATH == 'qemu-project/qemu'
I'm having dejavu about this exact problem previously this series was posted. Restricting based on CI_PROJECT_PATH is not desirable, because users should be free to bring up their own runners for this by following the instructions earlier in the series. Having to hack the .gitlab-ci.yml change this rule is going to be super unplesant. If we can't make it auto-skip when no runners are available, then we should set a rule based on a custom env variable. eg if "$QEMU_CI_RUNNER_S390" == "on" then all a contributor needs todo is set the variable in their gitlab repo preferences. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|