On 3/22/21 1:37 PM, Klaus Jensen wrote: > On Mar 22 10:58, Philippe Mathieu-Daudé wrote: >> On 3/22/21 9:24 AM, Joelle van Dyne wrote: >>> The check for `n->namespace.blkconf.blk` always fails because >>> this is in the initialization function. >> >> This usually mean the code depends to some state only available >> during the QOM 'realization' step, so this code should be in >> nvme_realize(). Maybe in this case we don't need it there and >> can add the property regardless a block drive is provided, I >> haven't checked. >> > > If we defer to realization, it won't be available as a parameter on the > command line, but as far as I can test, adding it unconditionally > doesn't break anything when there is no drive attached to the controller > device.
Patch is good then :)
