On 3/21/21 10:26 PM, David Gibson wrote:
On Mon, Mar 15, 2021 at 12:46:11PM -0600, Richard Henderson wrote:
We weren't recording MSR_GS in hflags, which means that BookE
memory accesses were essentially random vs Guest State.
Instead of adding this bit directly, record the completed mmu
indexes instead. This makes it obvious that we are recording
exactly the information that we need.
This also means that we can stop directly recording MSR_IR.
What still uses MSR_DR, that you can't also drop it?
#define CHK_HVRM \
do { \
if (unlikely(ctx->pr || !ctx->hv || ctx->dr)) { \
I have this notion that this (and CHK_HV and CHK_SV) could be a test against
mmu_idx instead, but was reluctant to make that change.
r~
