Hi Peter, On 3/25/21 4:33 PM, Peter Maydell wrote: > The function machine_class_allow_dynamic_sysbus_dev() is currently > undocumented; add a doc comment. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > include/hw/boards.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 4a90549ad85..27106abc11d 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -36,7 +36,21 @@ void machine_set_cpu_numa_node(MachineState *machine, > const CpuInstanceProperties *props, > Error **errp); > > +/** > + * machine_class_allow_dynamic_sysbus_dev: Add type to list of valid devices nit: s/of valid devices/of dynamically instantiable sysbus devices ? > + * @mc: Machine class > + * @type: type to whitelist (should be a subtype of TYPE_SYS_BUS_DEVICE) > + * > + * Add the QOM type @type to the list of devices of which are subtypes > + * of TYPE_SYS_BUS_DEVICE but which are still permitted to be dynamically > + * created (eg by the user on the command line with -device). > + * By default if the user tries to create any devices on the command line > + * that are subtypes of TYPE_SYS_BUS_DEVICE they will get an error message; > + * for the special cases which are permitted for this machine model, the > + * machine model class init code must call this function to whitelist them. > + */ > void machine_class_allow_dynamic_sysbus_dev(MachineClass *mc, const char > *type); > + > /* > * Checks that backend isn't used, preps it for exclusive usage and > * returns migratable MemoryRegion provided by backend. > Besides
Reviewed-by: Eric Auger <eric.au...@redhat.com> Thanks Eric
