On Fri, 26 Mar 2021 at 09:27, Auger Eric <eric.au...@redhat.com> wrote: > > Hi Peter, > > On 3/25/21 4:33 PM, Peter Maydell wrote: > > The function machine_class_allow_dynamic_sysbus_dev() is currently > > undocumented; add a doc comment. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > include/hw/boards.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > index 4a90549ad85..27106abc11d 100644 > > --- a/include/hw/boards.h > > +++ b/include/hw/boards.h > > @@ -36,7 +36,21 @@ void machine_set_cpu_numa_node(MachineState *machine, > > const CpuInstanceProperties *props, > > Error **errp); > > > > +/** > > + * machine_class_allow_dynamic_sysbus_dev: Add type to list of valid > > devices > nit: s/of valid devices/of dynamically instantiable sysbus devices ?
I was trying to keep the summary line to be one line, which doesn't give much space for nuance with a function name this long... -- PMM
