Patchew URL: https://patchew.org/QEMU/20210427220615.12763-1-space.monkey.deliv...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210427220615.12763-1-space.monkey.deliv...@gmail.com Subject: [PATCH v8 0/6] RISC-V Pointer Masking implementation === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210427220615.12763-1-space.monkey.deliv...@gmail.com -> patchew/20210427220615.12763-1-space.monkey.deliv...@gmail.com Switched to a new branch 'test' 0d3c038 Allow experimental J-ext to be turned on 2e8b023 Implement address masking functions required for RISC-V Pointer Masking extension 9cf6cf0 Support pointer masking for RISC-V for i/c/f/d/a types of instructions 583ea8a Print new PM CSRs in QEMU logs d674a6d Support CSRs required for RISC-V PM extension except for the h-mode 8f777b4 Add J-extension into RISC-V === OUTPUT BEGIN === 1/6 Checking commit 8f777b425749 (Add J-extension into RISC-V) 2/6 Checking commit d674a6dc8388 (Support CSRs required for RISC-V PM extension except for the h-mode) ERROR: open brace '{' following function declarations go on the next line #151: FILE: target/riscv/csr.c:193: +static int pointer_masking(CPURISCVState *env, int csrno) { WARNING: line over 80 characters #386: FILE: target/riscv/csr.c:1724: + [CSR_UMTE] = { "umte", pointer_masking, read_umte, write_umte }, WARNING: line over 80 characters #387: FILE: target/riscv/csr.c:1725: + [CSR_UPMMASK] = { "upmmask", pointer_masking, read_upmmask, write_upmmask }, WARNING: line over 80 characters #388: FILE: target/riscv/csr.c:1726: + [CSR_UPMBASE] = { "upmbase", pointer_masking, read_upmbase, write_upmbase }, WARNING: line over 80 characters #390: FILE: target/riscv/csr.c:1728: + [CSR_MMTE] = { "mmte", pointer_masking, read_mmte, write_mmte }, WARNING: line over 80 characters #391: FILE: target/riscv/csr.c:1729: + [CSR_MPMMASK] = { "mpmmask", pointer_masking, read_mpmmask, write_mpmmask }, WARNING: line over 80 characters #392: FILE: target/riscv/csr.c:1730: + [CSR_MPMBASE] = { "mpmbase", pointer_masking, read_mpmbase, write_mpmbase }, WARNING: line over 80 characters #394: FILE: target/riscv/csr.c:1732: + [CSR_SMTE] = { "smte", pointer_masking, read_smte, write_smte }, WARNING: line over 80 characters #395: FILE: target/riscv/csr.c:1733: + [CSR_SPMMASK] = { "spmmask", pointer_masking, read_spmmask, write_spmmask }, WARNING: line over 80 characters #396: FILE: target/riscv/csr.c:1734: + [CSR_SPMBASE] = { "spmbase", pointer_masking, read_spmbase, write_spmbase }, total: 1 errors, 9 warnings, 362 lines checked Patch 2/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/6 Checking commit 583ea8a026a6 (Print new PM CSRs in QEMU logs) 4/6 Checking commit 9cf6cf0a67f9 (Support pointer masking for RISC-V for i/c/f/d/a types of instructions) 5/6 Checking commit 2e8b02377249 (Implement address masking functions required for RISC-V Pointer Masking extension) 6/6 Checking commit 0d3c0387b1bb (Allow experimental J-ext to be turned on) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210427220615.12763-1-space.monkey.deliv...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com