Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers

[Richard Henderson]

On 09/28/2011 05:28 AM, Jan Kiszka wrote:
> +#if TCG_TARGET_REG_BITS == 64
> +    { INDEX_op_deposit8l_i32, { "r", "0", "r" } },
> +#else
> +    { INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } },
> +#endif

At minimum, abcd is spelled "q".

I don't particularly care for the 3 different opcodes.  Perhaps
we'd be better off with an inline predicate for when the deposit
opcode is "valid"?


r~