On 09/28/2011 07:33 AM, Jan Kiszka wrote: >> I don't particularly care for the 3 different opcodes. Perhaps >> we'd be better off with an inline predicate for when the deposit >> opcode is "valid"? > > We still need to dispatch at tcg generation time which variant is valid. Or > what do you have in mind?
Yes, but we'd know at tcg generation time that it *does* fit one of the few patterns you point out. The predicate would be used in e.g. tcg_gen_deposit_i32 to select either INDEX_op_deposit_i32 or the and/shift/and/or fallback. r~
