On Fri, 30 Apr 2021 at 17:33, Cédric Le Goater <c...@kaod.org> wrote: > > The following changes since commit 609d7596524ab204ccd71ef42c9eee4c7c338ea4: > > Update version for v6.0.0 release (2021-04-29 18:05:29 +0100) > > are available in the Git repository at: > > https://github.com/legoater/qemu/ tags/pull-aspeed-20210430 > > for you to fetch changes up to 1401dcd8aac9039797b995bfab078877a820c9c5: > > aspeed: Add support for the quanta-q7l1-bmc board (2021-04-30 10:30:42 > +0200) > > ---------------------------------------------------------------- > Aspeed patches : > > * Fixes for the DMA space > * New model for ASPEED's Hash and Crypto Engine (Joel and Klaus) > * Acceptance tests (Joel) > * A fix for the XDMA model > * Some extra features for the SMC controller. > * Two new boards : rainier-bmc and quanta-q7l1-bmc (Patrick) >
Fails to build, OSX: ../../hw/misc/aspeed_hace.c:128:49: error: incompatible pointer types passing 'size_t *' (aka 'unsigned long *') to parameter of type 'hwaddr *' (aka 'unsigned long long *') [-Werror,-Wincompatible-pointer-types] &iov[i].iov_len, false, ^~~~~~~~~~~~~~~ /Users/pm215/src/qemu-for-merges/include/exec/memory.h:2439:33: note: passing argument to parameter 'plen' here hwaddr *plen, bool is_write, MemTxAttrs attrs); ^ 1 error generated. (OpenBSD reports the same, but there it is only a warning.) Same thing is also a build failure on 32-bit hosts (where the types are genuinely different sizes): ../../hw/misc/aspeed_hace.c: In function 'do_hash_operation': ../../hw/misc/aspeed_hace.c:128:49: error: passing argument 3 of 'address_space_map' from incompatible pointer type [-Werror=incompatible-pointer-types] &iov[i].iov_len, false, ^ In file included from /home/peter.maydell/qemu/include/hw/sysbus.h:7:0, from /home/peter.maydell/qemu/include/hw/misc/aspeed_hace.h:12, from ../../hw/misc/aspeed_hace.c:14: /home/peter.maydell/qemu/include/exec/memory.h:2438:7: note: expected 'hwaddr * {aka long long unsigned int *}' but argument is of type 'size_t * {aka unsigned int *}' void *address_space_map(AddressSpace *as, hwaddr addr, ^~~~~~~~~~~~~~~~~ thanks -- PMM