The old function device_legacy_reset() (which was originally device_reset() and got renamed when 3-phase-reset landed) is deprecated, because it has slightly odd semantics -- it resets the device itself, but (unlike when a device is reset as part of system reset) not any qbus it owns (and devices attached to the qbus). The replacement is device_cold_reset(), which resets the device and its bus (if any).
For a device with child bus, the two functions are identical; this patchset changes the PPC code which uses device_legacy_reset() on devices which have no qbus to use device_cold_reset() instead; this should have no functionally visible difference. There is one other use of device_legacy_reset() in PPC code which I didn't change: in hw/ppc/spapr_pci.c:spapr_phb_children_reset(). I couldn't figure out what the children being reset here are and if they might own buses. I suspect that even if they do own buses the right thing would be to change to device_cold_reset(), but I stuck to only the changes I felt reasonably sure were definitely no-behaviour-change. NB: tested with 'make check' and 'make check-acceptance' only. thanks -- PMM Peter Maydell (3): hw/intc/spapr_xive: Use device_cold_reset() instead of device_legacy_reset() hw/ppc/spapr_vio: Reset TCE table object with device_cold_reset() hw/ppc/pnv_psi: Use device_cold_reset() instead of device_legacy_reset() hw/intc/spapr_xive.c | 2 +- hw/ppc/pnv_psi.c | 4 ++-- hw/ppc/spapr_vio.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -- 2.20.1