On Mon, May 03, 2021 at 04:18:48PM +0100, Peter Maydell wrote: > The spapr_vio_quiesce_one() function resets the TCE table object > (TYPE_SPAPR_TCE_TABLE) via device_legacy_reset(). We know that > objects of that type do not have a qbus of their own, so the new > device_cold_reset() function (which resets both the device and its > child buses) is equivalent here to device_legacy_reset() and we can > just switch to the new API. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Applied to ppc-for-6.1. Actually, I strongly suspect we could just change rtas_quiesce() to cold reset the entire VIO bus, but we can look at that as a followup after checking bit more closely. > --- > hw/ppc/spapr_vio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c > index ef06e0362c8..b59452bcd62 100644 > --- a/hw/ppc/spapr_vio.c > +++ b/hw/ppc/spapr_vio.c > @@ -310,7 +310,7 @@ int spapr_vio_send_crq(SpaprVioDevice *dev, uint8_t *crq) > static void spapr_vio_quiesce_one(SpaprVioDevice *dev) > { > if (dev->tcet) { > - device_legacy_reset(DEVICE(dev->tcet)); > + device_cold_reset(DEVICE(dev->tcet)); > } > free_crq(dev); > } -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature