On 5/13/21 7:58 PM, Paolo Bonzini wrote: > On 13/05/21 18:38, Philippe Mathieu-Daudé wrote: >> ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets. >> Move the variable assignment out of the block documented with >> "Uncomment the following lines to disable these optional devices". > > Can you document why it is always required in the commit message?
OK, basically SEMIHOSTING is not a device but an architectural thing. Maybe we are mixing various things, like a semihosting console (yes, a device) and the architectural part, I will discuss that with Alex. > I suppose you cannot move it to default-configs/targets/ because you > want to have CONFIG_SEMIHOSTING selected automatically (patch 9). That and other things. This is annoying me since more than 1 year. I'm waiting Claudio's ARM KVM/TCG series get merged before getting my hands dirty with meson.build. Let's postpone this patch (and the previous one) for now. Thanks for the review, Phil.
