On Wed, Oct 27, 2021 at 03:43:43AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 26, 2021 at 11:10:58AM -0400, Eduardo Habkost wrote: > > Rename the enums to match the naming style used by QAPI, and to > > use "32" and "64" instead of "20" and "31". This will allow us > > to more easily move the enum to the QAPI schema later. > > > > About the naming choice: "SMBIOS 2.1 entry point"/"SMBIO 3.0 > > typo in commit log
I'll fix it, thanks! > > > entry point" and "32-bit entry point"/"64-bit entry point" are > > synonymous in the SMBIOS specification. However, the phrases > > "32-bit entry point" and "64-bit entry point" are used more often. > > > > The new names also avoid confusion between the entry point format > > and the actual SMBIOS version reported in the entry point > > structure. For example: currently the 32-bit entry point > > actually report SMBIOS 2.8 support, not 2.1. > > > > Based on portions of a patch submitted by Daniel P. Berrangé. > > I think you need the original S.O.B here too then. I'm not sure it is appropriate here, as zero lines of code from the original patch remain here. > > > > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > --- > > First version of this code was submitted at: > > https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berra...@redhat.com > > > > Changes from v2: > > * Use "32" and "64" instead of "2_0" and "3_1" > > > > Changes from v1: > > * Patch was split in two > > * Hunks included this patch are not changed from v1 -- Eduardo
