Am 30.11.2021 um 10:46 hat Emanuele Giuseppe Esposito geschrieben: > drive_add is only used in softmmu/vl.c, so it can be a static > function there, and drive_def is only a particular use case of > qemu_opts_parse_noisily, so it can be inlined. > > Also remove drive_mark_claimed_by_board, as it is only defined > but not implemented (nor used) anywhere. > > Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
I don't think moving drive_add() actually improves anything. Yes, you can make it static, but in order to do that you had to introduce block_if_name() as a new public function and you're moving an obviously block related function to common code in vl.c. So this part doesn't look like a net win to me. The rest of the series looks good to me. Kevin
