On Fri, Jan 07, 2022 at 12:55:42PM +0100, Thomas Huth wrote: > On 07/01/2022 12.43, Andrea Bolognani wrote: > > On Thu, Aug 29, 2019 at 10:15:05AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > > > > libgcrypt may also be controlled by pkg-config, this patch adds > > > > pkg-config > > > > handling for libgcrypt. > > > > > > Where are you seeing pkg-config files for libgcrypt ? > > > > > > The upstream project has (frustratingly) been hostile to any proposal to > > > add pkg-config support saying people should stick with their custom > > > libgcrypt-config tool > > > > > > https://dev.gnupg.org/T2037 > > > > > > Even if this is something added by some distro downstream, what is the > > > benefit in using it, compared with libgcrypt-confg which should already > > > work & is portable. > > > > Resurrecting an old thread to point out that the upstream stance > > seems to have changed since that discussion: > > > > > > https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=97194b422bc89a6137f4e218d4cdee118c63e96e > > > > libgcrypt 1.9.0, released almost exactly a year ago, comes with a > > pkg-config file out of the box. With that in mind, I think it would > > make sense to re-evaluate this patch for inclusion. > > Maybe ... but we switched to Meson in between, so the patch needs to be > rewritten to use meson.build instead, I think. Also it seems like version > 1.9 is not available in all distros yet, so someone needs to do an > assessment whether the distros that use an older version of libgrypt provide > a .pc file or not...
Comes back to my question of what is the benefit of using the .pc file when what we have already works and is known to be portable. When using meson there is essentially zero burden to using the libgcrypt-config approach, because that's all handled transparently by meson. This is different from the situation with configure, where libgcrypt-config required extra work on our side. Overall I don't see any need to change it. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
